fix: match Cache-Control no-transform directive case-insensitively - #286
Merged
UlisesGascon merged 3 commits intoSep 9, 2026
Conversation
UlisesGascon
approved these changes
Sep 9, 2026
UlisesGascon
left a comment
UlisesGascon
left a comment
Member
There was a problem hiding this comment.
Thanks @vaibhavmashal for helping the project! This change will land in the next release. I refactored a bit the tests and included a small reference on the HISTORY.md
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #284
Per RFC 9111 Section 5.2, Cache-Control directives are compared case-insensitively. Previously, \compression\ checked for
o-transform\ case-sensitively, so headers like \Cache-Control: No-Transform\ or \Cache-Control: NO-TRANSFORM\ were not recognized and responses were still compressed.
Changes
o-transform\ prevent compression.